Only bind to ldap if configuration for the first server is set #10227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
changed the title
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
added
3. to review
juliusknorr
requested review from
GitHubUser4234,
MorrisJobke,
blizzz,
rullzer and
skjnldsv
skjnldsv
approved these changes
Jul 13, 2018
MorrisJobke
approved these changes
Jul 13, 2018
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Tested and works for single server setups as well. It still properly detects servers that are down and connects when they are up again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an infinite loop in setups with an backup ldap server as reported in #10160
We should only try to bind to ldap for the main server if we have a configuration set with doConnect at this point, otherwise there will be no resource for the connection set and establishConnection() will be called over and over again.