Include rooms in the list of candidates to share with #10256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxuliu
requested review from
MorrisJobke,
nickvergessen,
rullzer and
schiessle
danxuliu
force-pushed
the
add-support-for-room-shares
branch
3 times, most recently
from
d9d2cc2 to
aa5c1d1
Compare
| throw new QueryException(); | ||
| } | ||
|
|
||
| return $this->serverContainer->query(\OCA\Spreed\Share\Helper\DeletedShareAPIController::class); |
| throw new QueryException(); | ||
| } | ||
|
|
||
| return $this->serverContainer->query(\OCA\Spreed\Share\Helper\ShareAPIController::class); |
Member
There was a problem hiding this comment.
I dont like all this hardcoding :(
danxuliu
force-pushed
the
add-support-for-room-shares
branch
3 times, most recently
from
cd65e3e to
a693e11
Compare
danxuliu
force-pushed
the
add-support-for-room-shares
branch
from
a0c1f49 to
4b7fa4a
Compare
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
include-rooms-in-the-list-of-candidates-to-share-with
branch
from
dbc1277 to
49e6926
Compare
schiessle
approved these changes
Aug 8, 2018
Member
schiessle
left a comment
schiessle
left a comment
There was a problem hiding this comment.
tested and works as expected 👍
Member
|
@danxuliu @schiessle @nickvergessen 14 or 15? |
nickvergessen
approved these changes
Aug 24, 2018
nickvergessen
added
4. to release
MorrisJobke
deleted the
include-rooms-in-the-list-of-candidates-to-share-with
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #10255 (this pull request should be rebased onto master once #10255 is merged)
Requires nextcloud/spreed#1050