Skip to content

Make sure error_log() always receives a string #10355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Jul 23, 2018
Merged

Make sure error_log() always receives a string #10355

rullzer merged 1 commit into from
Jul 23, 2018

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jul 23, 2018

Talk integration tests were failing with, because the log was not writable and an "array" was logged:

[Mon Jul 23 16:26:36 2018] error_log() expects parameter 1 to be string, array given at /home/nickv/Nextcloud/14/server/lib/private/Log/File.php#148

@nickvergessen
Make sure error_log() always receives a string
b788f0a 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 14 milestone Jul 23, 2018
@rullzer rullzer merged commit f25d34b into master Jul 23, 2018
@rullzer rullzer deleted the bugfix/noid/make-sure-error-log-always-receives-a-string branch July 23, 2018 19:17
@MorrisJobke MorrisJobke mentioned this pull request Aug 20, 2018
Merged
@MorrisJobke
Copy link
Member

MorrisJobke commented Aug 20, 2018

Backport in #10760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @MorrisJobke @rullzer