Really cleanup the content-wrapper #10421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
added
enhancement
design
skjnldsv
requested review from
MorrisJobke,
danxuliu,
jancborchardt,
juliusknorr and
rullzer
juliusknorr
approved these changes
Jul 27, 2018
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
🙈 Yes, let's also get rid of this as well.
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
danxuliu
requested changes
Jul 30, 2018
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
Last commit broke the file list layout in the Files app:
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Member
Author
|
@danxuliu can you review again please? |
danxuliu
approved these changes
Jul 30, 2018
skjnldsv
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #10363
And #9982
No idea why I left this despite saying I removed it ^^