Skip to content

Conversation

@nickvergessen
Copy link
Member

…getTokenById

Signed-off-by: Joas Schilling coding@schilljs.com

Signed-off-by: Joas Schilling <coding@schilljs.com>
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bugfix/noid/this-database-dude

🙈

@kesselb
Copy link
Contributor

kesselb commented Sep 19, 2018

I see the same for

if ($token->getExpires() !== null && $token->getExpires() < $this->time->getTime()) {
where getToken and getTokenById differs

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

@danielkesselberg nice catch, added

@rullzer rullzer merged commit 92fa373 into master Sep 25, 2018
@rullzer rullzer deleted the bugfix/noid/this-database-dude branch September 25, 2018 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants