Allow the creationg of previews of files stored in appdata #11677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
added
3. to review
rullzer
requested review from
ChristophWurst,
MorrisJobke,
icewind1991,
juliusknorr and
nickvergessen
icewind1991
reviewed
Oct 8, 2018
| $view = new View($userFolder->getPath()); | ||
| $path = $userFolder->getRelativePath($file->getPath()); | ||
| } else { | ||
| $view = new View($file->getParent()->getPath()); |
Member
There was a problem hiding this comment.
cant you always use this code path?
To allow us to create previews of files stored in appdata we need to construct the view differently. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
feature/appdata_previews
branch
from
34db505 to
ade61d8
Compare
Member
Author
|
Ready for review |
juliusknorr
reviewed
Oct 8, 2018
juliusknorr
approved these changes
Oct 9, 2018
MorrisJobke
approved these changes
Oct 9, 2018
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Tested and works 👍 Also the code makes sense
This was referenced Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow us to create previews of files stored in appdata we need to
construct the view differently.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl