Ignore "session_lifetime" if it can not be converted to a number #11756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When "session_lifetime" can not be converted to a number the interval becomes a NaN due to dividing it by 2. This NaN was "dragged" over all the other mathematical operations and caused the csrftoken to be got again and again due to an infinite loop with no pauses in "setInterval". Now, the interval is set to the default value instead if the "session_lifetime" can not be converted to a number. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
ChristophWurst
approved these changes
Oct 11, 2018
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Wow, nice catch! Thanks!
rullzer
approved these changes
Oct 11, 2018
rullzer
deleted the
ignore-session-lifetime-if-it-can-not-be-converted-to-a-number
branch
Member
|
Fixes #11747 |
This was referenced Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
session_lifetimecan not be converted to a number the interval becomes a NaN due to dividing it by 2. This NaN was dragged over all the other mathematical operations and caused the csrftoken to be got again and again due to an infinite loop with no pauses insetInterval. Now, the interval is set to the default value instead if thesession_lifetimecan not be converted to a number.