Skip to content

Polishing of various modal dialogs #12762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Dec 3, 2018
Merged

Polishing of various modal dialogs #12762

skjnldsv merged 1 commit into from
Dec 3, 2018

Conversation

@jancborchardt
Copy link
Member

@jancborchardt jancborchardt commented Nov 30, 2018

Dialogs to test with:

  • Authentication dialog e.g. when installing apps: Button to right, margins fixed.
    authentication dialog
  • File picker / Move or copy dialog: Fade on bottom right not fully overlapping scrollbar (cause of border-radius) fixed.
    copymove border radius
  • Avatar cropper in personal settings: Adjusted border-radii and drop-shadows to standard.
    avatar cropper
  • File conflict dialog in files: No change.

@jancborchardt
Fix dialogs, button position
2824622 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt jancborchardt added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Nov 30, 2018
@jancborchardt jancborchardt added this to the Nextcloud 15 milestone Nov 30, 2018
@jancborchardt jancborchardt mentioned this pull request Nov 30, 2018
Closed
47 tasks
@weeman1337
Copy link
Member

weeman1337 commented Nov 30, 2018

Looks neat!

@jancborchardt
Copy link
Member Author

jancborchardt commented Dec 2, 2018

What about the Drone checks here? Is this really blocking? cc @MorrisJobke @rullzer cause it’s polishing in several places.

@skjnldsv
Copy link
Member

skjnldsv commented Dec 3, 2018

Failure unrelated!

@skjnldsv
Copy link
Member

skjnldsv commented Dec 3, 2018

/backport to stable15

@skjnldsv skjnldsv merged commit e7458a4 into master Dec 3, 2018
@skjnldsv skjnldsv deleted the auth-dialog-fix branch December 3, 2018 06:30
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 3, 2018
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Dec 3, 2018

backport to stable15 in #12784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weeman1337 weeman1337 weeman1337 approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@violoncelloCH violoncelloCH Awaiting requested review from violoncelloCH

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc.

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

4 participants

@jancborchardt @weeman1337 @skjnldsv