Use default cursor for disabled primary buttons #13003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabled buttons use the default cursor, but as the cursor property for primary buttons is set after the cursor property for disabled buttons the latter is always overridden, even if the primary button is also disabled. Due to this it is necessary to explicitly set the default cursor for disabled primary buttons. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
jancborchardt
approved these changes
Dec 11, 2018
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Good detail fix! :)
Not sure it needs a backport, but it seems very low-risk. So your call.
Member
Author
In general I would not backport something like that, but in this specific case I would make an exception given that Nextcloud 15 was just released, it is related to one of the new features in Nextcloud 15 (the Talk sidebar) and it is very low-risk. So... I will summon backport-bot ;-) |
Member
Author
|
/backport to stable15 |
skjnldsv
approved these changes
Dec 11, 2018
jancborchardt
deleted the
use-default-cursor-for-disabled-primary-buttons
branch
|
backport to stable15 in #13007 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled buttons use the default cursor, but as the cursor property for primary buttons is set after the cursor property for disabled buttons the latter is always overridden, even if the primary button is also
disabled. Due to this it is necessary to explicitly set the default cursor for disabled primary buttons.
@nextcloud/designers
Before:
After:
I would backport this at least to stable15.