Only trust the X-FORWARDED-HOST header for trusted proxies #13116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
should also patch getServerProtocol Other than that 👍 good hardening |
nickvergessen
approved these changes
Dec 17, 2018
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
fix/only_trust_xforwardedhost_for_trusted_proxies
branch
from
7680e00 to
514426e
Compare
kesselb
approved these changes
Dec 17, 2018
Member
Anything missing? |
Member
Author
|
Litmus is failing. But unrelated I think |
rullzer
added
3. to review
Member
Author
|
/backport to stable15 |
Member
Author
|
Yep fails becaus of 740ea0d30e8e |
rullzer
deleted the
fix/only_trust_xforwardedhost_for_trusted_proxies
branch
|
backport to stable15 in #13150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl