Skip to content

Prevent special characters from breaking the file drop remote url #13133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Dec 19, 2018
Merged

Prevent special characters from breaking the file drop remote url #13133

rullzer merged 1 commit into from
Dec 19, 2018

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 18, 2018

  1. create a share file drop
  2. upload the following file
  3. see that empty files are being uploaded
    capture d ecran_2018-12-18_09-20-04

Broken file test:
#Test.txt

@skjnldsv
Prevent special characters from breaking the file drop remote url
bd3b227 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added this to the Nextcloud 16 milestone Dec 18, 2018
@skjnldsv skjnldsv self-assigned this Dec 18, 2018
@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 18, 2018

/backport to stable15

@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 18, 2018

/backport to stable14

@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 18, 2018

/backport to stable13

ChristophWurst
ChristophWurst approved these changes Dec 18, 2018
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 18, 2018

Failure unrelated!

rullzer
rullzer approved these changes Dec 19, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@rullzer rullzer merged commit 7214a8e into master Dec 19, 2018
@rullzer rullzer deleted the file-drop-char-fixes branch December 19, 2018 08:54
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 19, 2018
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Dec 19, 2018

backport to stable15 in #13151

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 19, 2018
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Dec 19, 2018

backport to stable14 in #13152

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 19, 2018
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Dec 19, 2018

backport to stable13 in #13153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews bug feature: files

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @rullzer @ChristophWurst