Skip to content

returns a 404 instead of exception if app is not installed - #13088 #13134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 2 commits into from
Jan 4, 2019
Merged

returns a 404 instead of exception if app is not installed - #13088 #13134

MorrisJobke merged 2 commits into from
Jan 4, 2019

Conversation

@ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Dec 18, 2018 •
edited by juliusknorr
Loading

Fixes #13088

@ArtificialOwl ArtificialOwl added the 3. to review Waiting for reviews label Dec 18, 2018
@ArtificialOwl
Copy link
Member Author

ArtificialOwl commented Dec 18, 2018

backport to 15 will be needed

@juliusknorr
Copy link
Member

juliusknorr commented Dec 18, 2018

I guess we should adjust the setup check in the same run, it probably still fails if a 404 code is returned.

@juliusknorr
Copy link
Member

juliusknorr commented Dec 18, 2018

/backport to stable15

@juliusknorr juliusknorr added this to the Nextcloud 16 milestone Dec 18, 2018
ArtificialOwl and others added 2 commits December 19, 2018 07:41
@ArtificialOwl @juliusknorr
returns a 501 instead of exception if app is not installed - #13088
fb7840b 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@juliusknorr
Make setup check also pass with a 501 status
a3be286 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/13088/404-instead-of-exception branch from deefb9e to a3be286 Compare December 19, 2018 06:41
@juliusknorr
Copy link
Member

juliusknorr commented Dec 19, 2018

As discussed with @daita we use a 501 Not implemented now, so we can properly check if the url rewrite is properly setup even if there is no app hooking into the webfinger endpoint.

@juliusknorr
Copy link
Member

juliusknorr commented Jan 3, 2019

Would be good to get this in, so we probably can get the backport for stable15 in 15.0.1.

rullzer
rullzer approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@rullzer
Copy link
Member

rullzer commented Jan 4, 2019

/backport to stable15

MorrisJobke
MorrisJobke approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 0aa30b7 into master Jan 4, 2019
@MorrisJobke MorrisJobke deleted the bugfix/13088/404-instead-of-exception branch January 4, 2019 16:08
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 4, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 4, 2019

backport to stable15 in #13357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@danxuliu danxuliu Awaiting requested review from danxuliu

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

5 participants

@ArtificialOwl @juliusknorr @rullzer @MorrisJobke