Skip to content

[WIP] Use new appstore endpoint #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LukasReschke wants to merge 2 commits into from
Closed

[WIP] Use new appstore endpoint #1335

LukasReschke wants to merge 2 commits into from

Conversation

@LukasReschke
Copy link
Member

@LukasReschke LukasReschke commented Sep 9, 2016 •
edited
Loading

Completely WIP.

TODOs:

  • Categories are read and displayed
  • Filtering apps from the appstore in categories work
  • Adjust JS to work with the response returned by the appstore OR adjust the response in the controller (whatever makes more sense)
  • Re-add "Enabled" and "Disabled" in the response for all apps
  • Proper update notification for apps
  • L10N for app descriptions and titles
  • Download JSON responses only once (and in the background as cron job) and store with Introducing AppData #1306
  • No more "TODOs" and "FIXME" in the code
  • Adjust unit tests

@LukasReschke LukasReschke added the 2. developing Work in progress label Sep 9, 2016
@LukasReschke LukasReschke added this to the Nextcloud 11.0 milestone Sep 9, 2016
@mention-bot
Copy link

mention-bot commented Sep 9, 2016

@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @nickvergessen, @DeepDiver1975 and @MorrisJobke to be potential reviewers

nickvergessen
nickvergessen reviewed Sep 9, 2016
View reviewed changes
settings/Controller/AppSettingsController.php Outdated
'displayName' => (string)$this->l10n->t('Enabled'),
],
[
'id' => 'enabled',
Copy link
Member

@nickvergessen nickvergessen Sep 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@nickvergessen nickvergessen self-assigned this Sep 9, 2016
LukasReschke and others added 2 commits September 9, 2016 17:08
@LukasReschke
Add initial support for the new appstore
be3b83a 
- List categories
- Filter apps in categories
@nickvergessen @LukasReschke
Fix minor things
83d45d1
@LukasReschke LukasReschke force-pushed the use-new-appstore-endpoint branch from e6501ba to 83d45d1 Compare September 9, 2016 15:08
@rullzer
Copy link
Member

rullzer commented Nov 3, 2016

We have the new appstore in. So this can 🔥

@rullzer rullzer closed this Nov 3, 2016
@rullzer rullzer deleted the use-new-appstore-endpoint branch November 3, 2016 14:39
@AkshayraviC09YC47 AkshayraviC09YC47 mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nickvergessen nickvergessen

Labels

2. developing Work in progress

Projects

None yet

Milestone

Nextcloud 11.0

Development

Successfully merging this pull request may close these issues.

5 participants

@LukasReschke @mention-bot @rullzer @nickvergessen