Skip to content

Conversation

@ChristophWurst
Copy link
Member

No description provided.

@ChristophWurst
Copy link
Member Author

Loading the files app on master: 104 js files loaded
this branch: 89

And I'm not even done 🚀

@ChristophWurst
Copy link
Member Author

I think I might stop at this point before this gets even less reviewable. It's possible to do this transition in another one or two PRs.

@ChristophWurst
Copy link
Member Author

  • BUG: after a local file is selected for upload, nothing happens. no error, no upload, no visual changes.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the refactor/core-js-bundle branch from 1cb1674 to 6fa8844 Compare January 17, 2019 13:18
@ChristophWurst
Copy link
Member Author

@juliushaertl I've rebased onto master to resolve conflicts from #13407. Please have a look if I applied the changes correctly (should you find them in this huge diff).

import OCA from './oca';
import escapeHTML from './util/escapeHTML'
import './jquery.avatar';
import './jquery.contactsmenu';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about having a separate chunk for code that is only required when a user is logged in?
Besides the contactsmenu, when looking at core.json we probably also don't need to load systemtags/setupchecks on public pages.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! We can definitely try to load them only if required. We just have to check if the code still runs 😉

@juliusknorr
Copy link
Member

@juliushaertl I've rebased onto master to resolve conflicts from #13407. Please have a look if I applied the changes correctly (should you find them in this huge diff).

Looks good.

@ChristophWurst
Copy link
Member Author

Thanks for checking! I've now also added folders in src for OCA and OCP. I like what you did with OC on the other branch. This keeps the scripts a bit more organized :)

@ChristophWurst
Copy link
Member Author

Alright, this introduced a little 🐛 I'm unable to find 🔍. I'll do this in a bunch of smaller, more reviewable PRs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants