Use warning background color & primary text color for setting warnings #13664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
added
bug
design
MorrisJobke
requested review from
ChristophWurst,
jancborchardt,
juliusknorr and
skjnldsv
ChristophWurst
added
4. to release
Member
Author
|
/backport to stable15 |
Member
Author
|
/backport to stable14 |
This was referenced Jan 18, 2019
|
backport to stable15 in #13665 |
|
backport to stable14 in #13666 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found in nextcloud/user_saml#298
Looks like this:
The link was not visible by default so I adjusted the warning box to look like in the screenshots. I will open a server PR soon.
@nextcloud/designers I guess we should add such stuff to the dev docs, right?
I would also backport it to stable14 and 15.