-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
trim filename in webfrontend for windows compatibility #13947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
juliusknorr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense 👍
|
Thanks a lot for your contribution. 🚀 There is only one thing missing - you need to add a sign-off message to the commits you made. Read more about this in https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#sign-your-work |
ChristophWurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
while @juliushaertl is correct for small changes it is ok. Just sign your next contribution :D Welcome to the club @aignerat |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
/backport to master |
|
backport to master in #13972 |
|
Ah my bad I merged to soon. 15 is in RC. |
Yep - let's revert this for now and then backport #13972 again. @aignerat Sorry for the trouble here. |
|
Fix #11666 |
Added trim function in javascript to ensure compatibility with windows
scenario: I create the file "test.txt " and can't synchronize it with my local file-base. The same issue happens with folders with whitespaces at the begin or end. This feature ensures that a windows-user can't create the same circumstance for himself accidentally.