Skip to content

Conversation

@aignerat
Copy link
Member

Added trim function in javascript to ensure compatibility with windows

scenario: I create the file "test.txt " and can't synchronize it with my local file-base. The same issue happens with folders with whitespaces at the begin or end. This feature ensures that a windows-user can't create the same circumstance for himself accidentally.

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@juliusknorr
Copy link
Member

Thanks a lot for your contribution. 🚀

There is only one thing missing - you need to add a sign-off message to the commits you made. Read more about this in https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#sign-your-work

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish 3. to review Waiting for reviews and removed 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish labels Feb 1, 2019
@rullzer
Copy link
Member

rullzer commented Feb 1, 2019

while @juliushaertl is correct for small changes it is ok. Just sign your next contribution :D Welcome to the club @aignerat

@rullzer rullzer merged commit 3d399a5 into nextcloud:stable15 Feb 1, 2019
@welcome
Copy link

welcome bot commented Feb 1, 2019

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@rullzer
Copy link
Member

rullzer commented Feb 1, 2019

/backport to master

@backportbot-nextcloud
Copy link

backport to master in #13972

@rullzer
Copy link
Member

rullzer commented Feb 1, 2019

Ah my bad I merged to soon. 15 is in RC.
@MorrisJobke shall we revert?

@MorrisJobke
Copy link
Member

Ah my bad I merged to soon. 15 is in RC.
@MorrisJobke shall we revert?

Yep - let's revert this for now and then backport #13972 again.

@aignerat Sorry for the trouble here.

@kesselb
Copy link
Contributor

kesselb commented Feb 3, 2019

Fix #11666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants