-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix folder drag glitch in Firefox #1406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
issue: * drag'n'drop a folder into the files app in Firefox * the highlight stays there because Firefox doesn't trigger the drop event for folders solution: * behave like the drop event if the dragover event isn't fired for 100ms (only applied in Firefox)
|
@MorrisJobke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @vincchan, @butonic and @luckydonald to be potential reviewers |
|
But the error message still doesnt come anymore? Can we create that as well manually? |
This is not there in stable9 as well. I would make this an additional PR |
also in stable8.2 there was no dialog. I also tried to get an event for the folder drop, but firefox doesn't trigger anything. I guess it simply isn't invoke by Firefox and we can't do much here. |
Just tested and yes, seems to indeed be broken a long time :( |
|
👍 |
|
Review @LukasReschke @MariusBluem |
|
LGTM |
|
@nickvergessen I guess it's better to backport this to stable10, right? |
|
Yup, quite irritating otherwise |
issue:
solution:
cc @vincchan @rullzer @raghunayyar @LukasReschke