Skip to content

Conversation

@MorrisJobke
Copy link
Member

issue:

  • drag'n'drop a folder into the files app in Firefox
  • the highlight stays there because Firefox doesn't trigger the drop event for folders

solution:

  • behave like the drop event if the dragover event isn't fired for 100ms (only applied in Firefox)

cc @vincchan @rullzer @raghunayyar @LukasReschke

issue:
* drag'n'drop a folder into the files app in Firefox
* the highlight stays there because Firefox doesn't trigger the drop event for folders

solution:
* behave like the drop event if the dragover event isn't fired for 100ms (only applied in Firefox)
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Sep 14, 2016
@MorrisJobke MorrisJobke added this to the Nextcloud 11.0 milestone Sep 14, 2016
@mention-bot
Copy link

@MorrisJobke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @vincchan, @butonic and @luckydonald to be potential reviewers

@nickvergessen
Copy link
Member

But the error message still doesnt come anymore? Can we create that as well manually?

@MorrisJobke
Copy link
Member Author

But the error message still doesnt come anymore? Can we create that as well manually?

This is not there in stable9 as well. I would make this an additional PR

@MorrisJobke
Copy link
Member Author

This is not there in stable9 as well. I would make this an additional PR

also in stable8.2 there was no dialog.

I also tried to get an event for the folder drop, but firefox doesn't trigger anything. I guess it simply isn't invoke by Firefox and we can't do much here.

@nickvergessen
Copy link
Member

This is not there in stable9 as well. I would make this an additional PR

also in stable8.2 there was no dialog.

Just tested and yes, seems to indeed be broken a long time :(

@nickvergessen
Copy link
Member

👍

@nickvergessen
Copy link
Member

Review @LukasReschke @MariusBluem

@LukasReschke
Copy link
Member

LGTM

@LukasReschke LukasReschke merged commit 0c6957d into master Sep 26, 2016
@LukasReschke LukasReschke deleted the fix-folder-drop-in-firefox branch September 26, 2016 11:10
@MorrisJobke
Copy link
Member Author

@nickvergessen I guess it's better to backport this to stable10, right?

@nickvergessen
Copy link
Member

Yup, quite irritating otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants