Move files_sharing additionalscripts over to webpack #14218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
requested review from
ChristophWurst,
MorrisJobke,
juliusknorr and
skjnldsv
Member
|
Isn't the compiled asset missing here? |
Member
Yep - no sharing anymore in the files app 😉 |
Member
Author
|
details... yeah let me add it |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
enh/files_sharing_to_webpack
branch
from
4c176a8 to
0a4569d
Compare
skjnldsv
approved these changes
Feb 19, 2019
skjnldsv
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13649 However that PR tries to do more.
This just moves the additionalscripts bundling from our own bundling to webpack.
Saves an additional request as we bundle the scss now as well.