Skip to content

allow group backends to mark that a group should now be shown in search dialogs #14347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 2 commits into from
Feb 25, 2019
Merged

allow group backends to mark that a group should now be shown in search dialogs #14347

rullzer merged 2 commits into from
Feb 25, 2019
+79 −1

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Feb 22, 2019

use case here is hiding the virtual "guests" group from sharing when using the guests app

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Feb 22, 2019
@icewind1991 icewind1991 added this to the Nextcloud 16 milestone Feb 22, 2019
rullzer
rullzer approved these changes Feb 24, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some tests would be nice

blizzz
blizzz requested changes Feb 25, 2019
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, generally, but autoloader files needs to get updated and some PHP docs are missing (see CI)

@icewind1991 icewind1991 force-pushed the hide-collaboration-groups branch from 760c4a7 to 43d14da Compare February 25, 2019 14:05
@icewind1991
allow group backends to mark that a group should now be shown in sear…
db75089 
…ch dialogs

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the hide-collaboration-groups branch from 43d14da to db75089 Compare February 25, 2019 15:06
@MorrisJobke
Copy link
Member

MorrisJobke commented Feb 25, 2019

Looks fine, generally, but autoloader files needs to get updated and some PHP docs are missing (see CI)

I updated the autoloader files.

@MorrisJobke
Update autoloader files
dd95f43 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
MorrisJobke approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 25, 2019
@rullzer rullzer merged commit ee5e767 into master Feb 25, 2019
@rullzer rullzer deleted the hide-collaboration-groups branch February 25, 2019 20:24
@nickvergessen nickvergessen mentioned this pull request Jul 2, 2021
Merged
@kesselb kesselb mentioned this pull request May 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz blizzz requested changes

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

5 participants

@icewind1991 @MorrisJobke @rullzer @blizzz