Use a tmp file for swift writes #14424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
can you add a check to see if the source stream is already seekable |
Member
Author
done. Please have another look |
Else this leads to a seekable stream error with chunked uploads Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
fix/13554/swift_to_tmp
branch
from
dd568a1 to
1153123
Compare
icewind1991
approved these changes
Mar 6, 2019
Member
Author
|
/backport to stable15 |
|
backport to stable15 in #14570 |
Contributor
|
@rullzer With the latest commit in stable15 I still get a similar error: "Unable to seek to stream position 0 with whence 0" in files bigger than 10mb. Removing the negation in isset fixed it for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13554
Else this leads to a seekable stream error with chunked uploads
@icewind1991 I know this is not the ideal solution. but this is at least trivial to backport to 15.