Skip to content

Rename collections to projects #14990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 5 commits into from
Apr 10, 2019
Merged

Rename collections to projects #14990

rullzer merged 5 commits into from
Apr 10, 2019

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Apr 8, 2019 •
edited
Loading

As discussed with @jancborchardt @jospoortvliet

image

@juliusknorr juliusknorr added 2. developing Work in progress papercut Annoying recurring UX issue with possibly simple fix. labels Apr 8, 2019
@juliusknorr juliusknorr added this to the Nextcloud 16 milestone Apr 8, 2019
@juliusknorr juliusknorr added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 8, 2019
@juliusknorr juliusknorr mentioned this pull request Apr 8, 2019
Merged
@MorrisJobke
Copy link
Member

MorrisJobke commented Apr 8, 2019

Webpack complains about changes in the compiled assets.

ghost
ghost reviewed Apr 8, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is escapeHTML not marked deprecated?

@nickvergessen
Copy link
Member

nickvergessen commented Apr 8, 2019

It is, but there is no replacement yet, so using it is still fine

@juliusknorr
Add projects icon
0cdc671 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Rename collections to projects
e1ae0d1 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Bump nextcloud-vue-collections
b518a65 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Use label from apps
b479af8 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Bump bundles
53b2375 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the enhancement/noid/projects branch from ef7891c to 53b2375 Compare April 9, 2019 06:36
@juliusknorr
Copy link
Member Author

juliusknorr commented Apr 9, 2019

Webpack complains about changes in the compiled assets.

Updated.

jancborchardt
jancborchardt approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, easier to understand! :)

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 9, 2019
@rullzer rullzer mentioned this pull request Apr 10, 2019
Merged
13 tasks
@rullzer rullzer merged commit ad82c26 into master Apr 10, 2019
@rullzer rullzer deleted the enhancement/noid/projects branch April 10, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@jospoortvliet jospoortvliet Awaiting requested review from jospoortvliet

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish papercut Annoying recurring UX issue with possibly simple fix.

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

6 participants

@juliusknorr @MorrisJobke @nickvergessen @jancborchardt @rullzer