Return ETag and OC-ETag in case of a move (#25683) #1513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @blizzz, @nickvergessen and @MorrisJobke to be potential reviewers |
Member
|
👍 |
Member
|
Tested and works 👍 Header is now included |
Downstreaming of owncloud/core#25683 Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
LukasReschke
force-pushed
the
fix-etag-on-move
branch
from
601cd17 to
bd96c6a
Compare
Member
Author
|
Rebased upon master. |
Current coverage is 30.68% (diff: 64.28%)@@ master #1513 diff @@
==========================================
Files 1080 1080
Lines 59827 59836 +9
Methods 6771 6772 +1
Messages 0 0
Branches 0 0
==========================================
+ Hits 18353 18361 +8
- Misses 41474 41475 +1
Partials 0 0
|
Member
|
Retested and works 👍 |
MorrisJobke
approved these changes
Sep 28, 2016
Member
|
This was backported upstream - owncloud/core#26334 Should we also backport this? |
Member
Author
|
I guess so, assuming the clients use that probably 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstreaming of owncloud/core#25683
Signed-off-by: Lukas Reschke lukas@statuscode.ch