Fix mapper not properly casting int in oauth2 code

[rullzer]

Else this does 💥

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

[rullzer]

/backport to stable16

[kesselb]

server/apps/oauth2/lib/Db/AccessToken.php

Line 36 in 97321f6

class AccessToken extends Entity {

I think we should fix the getter otherwise we have to cast it on every occurrence.

[nickvergessen]

Well actually

server/apps/oauth2/lib/Db/AccessToken.php

Line 49 in 5f71805

$this->addType('client_id', 'int');

should do exactly that.

[nickvergessen]

So I would fix

server/lib/public/AppFramework/Db/Entity.php

Lines 126 to 128 in ba87db3

	if(property_exists($this, $name)){
	return $this->$name;
	} else {

instead.

[kesselb]

Any idea what is broken? If the record is populated from DB the values should be set through the setters. We could migrate to QBMapper for 17.

[rullzer]

I have no idea why it does 💥 but it was reported and did 💥 for me on a 16 test with php 7.1 (no xdebug there).

I propose to just get this in and fix it properly later.

[kesselb]

Sure. I still vote for a getter in accesstoken and do the type cast there.

[rullzer]

Ah sure that is fine as well

[rullzer]

Ah. so it was actually because the wront names were used for setting the types 🙈

[ChristophWurst]

🙈

[kesselb]

You found the real mistake 🚀

[backportbot-nextcloud]

backport to stable16 in #15215