Fix multiselect bar overlapping recommendations #15164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardt
added
bug
design
jancborchardt
requested review from
ChristophWurst,
MorrisJobke,
newhinton and
skjnldsv
skjnldsv
approved these changes
Apr 18, 2019
Member
Author
|
Backport to stable16 at #15166 if needed. |
Member
you could have use the backport bot? :) |
Member
Author
Yeah, I remembered directly after I opened the backport 🤦♂️ :D What’s the syntax again? |
Member
|
/backport to stable16 |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
added
4. to release
skjnldsv
previously requested changes
Apr 18, 2019
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Please use @include position('sticky'); then. It will do it automatically :)
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
ChristophWurst
approved these changes
Apr 18, 2019
|
backport to stable16 in #15198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix nextcloud/recommendations#29 please review @MorrisJobke @ChristophWurst @nextcloud/designers
Before:
After:
And even sticky when scrolling:
