Skip to content

Conversation

@rmanibus
Copy link

Fix #14986

@rmanibus
Copy link
Author

After a closer look at the code it seems that this should only be included if it's a folder. I will update the PR

@rmanibus
Copy link
Author

it seems that file_sharing scripts

			\OCP\Util::addScript('files_sharing', 'public');
			\OCP\Util::addScript('files_sharing', 'templates');
			\OCP\Util::addScript('files_sharing', 'files_drop');

need to be included before files app scripts for the folder view and after the files app scripts for the single file view.

@rmanibus
Copy link
Author

There is still an problem on new folder creation. The folder is correctly created but the in the js console there is the following error:

TypeError: this._detailsView is null

This error is also existing without this fix.

Signed-off-by: Loïc Hermann <loic.hermann@sciam.fr>
@rmanibus rmanibus force-pushed the fix/14986/upload_via_shared_link branch from 6899a52 to 2f36546 Compare April 19, 2019 12:48
Signed-off-by: Loïc Hermann <loic.hermann@sciam.fr>
@enoch85
Copy link
Member

enoch85 commented May 6, 2019

@rullzer I'm not 100% sure here, but his fix solved the issue for me at least.

Maybe we can add this in 16.0.1? Public shares are currently broken without this.

@violoncelloCH
Copy link
Member

this was fixed in the meantime by #15432 so I guess we can close this? cc @MorrisJobke

@enoch85 enoch85 closed this May 9, 2019
@enoch85
Copy link
Member

enoch85 commented May 9, 2019

Thanks for your efforts @rmanibus!

@rmanibus rmanibus deleted the fix/14986/upload_via_shared_link branch May 9, 2019 11:54
@MorrisJobke
Copy link
Member

This is still there.

@nextcloud/javascript Does it still make sense to go for this approach?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upload via shared link fails on nextcloud 16.0.0RC2

4 participants