Skip to content

Fix multiselect min width #15301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
May 7, 2019
Merged

Fix multiselect min width #15301

MorrisJobke merged 1 commit into from
May 7, 2019

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Apr 30, 2019

fix #15246

@nextcloud/designers @j-ed

@skjnldsv
Fix multiselect min width
100b998 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Apr 30, 2019
@skjnldsv skjnldsv added this to the Nextcloud 17 milestone Apr 30, 2019
@skjnldsv skjnldsv self-assigned this Apr 30, 2019
@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 30, 2019

/backport to stable16

@jancborchardt jancborchardt requested a review from mmccarn April 30, 2019 15:41
@jancborchardt
Copy link
Member

jancborchardt commented Apr 30, 2019

Please check if this fixes your issue @j-ed @mmccarn :)

@j-ed
Copy link
Contributor

j-ed commented Apr 30, 2019

The original problem, the missing breadcrumbs behind a record, has been solved but now the whole user list looks a little bit shaky:

grafik

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 30, 2019

@j-ed it should absolutely not look like that.
Could you refresh your cache? :)

@j-ed
Copy link
Contributor

j-ed commented Apr 30, 2019

@skjnldsv I've explicitly tested it with a Firefox test profile, where I had deleted all cached data before I logged-into Nextcloud. For you I've repeated the test and got the same result.

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 30, 2019

Even the server css cache? (occ maintenance:repair)
Capture d’écran_2019-04-30_19-10-09

@j-ed
Copy link
Contributor

j-ed commented Apr 30, 2019

Sorry, I cannot see any improvement although I've cleared the server cache as you requested.

@MorrisJobke
Copy link
Member

MorrisJobke commented May 2, 2019

The original problem, the missing breadcrumbs behind a record, has been solved but now the whole user list looks a little bit shaky:

I can't reproduce this here.

@skjnldsv
Copy link
Member Author

skjnldsv commented May 2, 2019

Me neither. I'd say a checkout issue maybe? Or a cache problem again. 🤷‍♀️

@skjnldsv
Copy link
Member Author

skjnldsv commented May 7, 2019

Bump

MorrisJobke
MorrisJobke approved these changes May 7, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works here 👍

@MorrisJobke MorrisJobke merged commit 8fadc82 into master May 7, 2019
@MorrisJobke MorrisJobke deleted the fix/select/users-management branch May 7, 2019 21:54
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 7, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented May 7, 2019

backport to stable16 in #15433

@ChristophWurst ChristophWurst mentioned this pull request May 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@kesselb kesselb Awaiting requested review from kesselb

@mmccarn mmccarn Awaiting requested review from mmccarn

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc.

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

NC 16 - breadcrumb menu in user management not shown anymore

6 participants

@skjnldsv @jancborchardt @j-ed @MorrisJobke @ChristophWurst