Skip to content

remove setup args from logging #15308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 3 commits into from
May 8, 2019
Merged

remove setup args from logging #15308

MorrisJobke merged 3 commits into from
May 8, 2019

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Apr 30, 2019

fixes #13550

@blizzz blizzz added this to the Nextcloud 17 milestone Apr 30, 2019
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 30, 2019
@blizzz
Copy link
Member Author

blizzz commented Apr 30, 2019

/backport to stable16

@blizzz
Copy link
Member Author

blizzz commented Apr 30, 2019

/backport to stable15

@blizzz
Copy link
Member Author

blizzz commented Apr 30, 2019

/backport to stable14

@skjnldsv
Copy link
Member

skjnldsv commented Apr 30, 2019

Thanks @blizzz :D

nickvergessen
nickvergessen reviewed Apr 30, 2019
View reviewed changes
@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels May 6, 2019
blizzz added 2 commits May 6, 2019 23:59
@blizzz
remove setup args from logging
4ad8d0c 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
remove args from logging of common-spelled methods dependent on class
d6d1666 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the fix/13550/logging branch from 0d880b2 to d6d1666 Compare May 6, 2019 22:20
@blizzz blizzz added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 6, 2019
@blizzz blizzz requested a review from nickvergessen May 7, 2019 07:44
nickvergessen
nickvergessen requested changes May 7, 2019
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class might be undefined:
https://3v4l.org/niqG4

@MorrisJobke MorrisJobke removed the 3. to review Waiting for reviews label May 7, 2019
@MorrisJobke MorrisJobke added the 2. developing Work in progress label May 7, 2019
@nickvergessen @blizzz
fix class might be undefined
a79da34 
Co-Authored-By: blizzz <blizzz@arthur-schiwon.de>

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the fix/13550/logging branch from e790540 to a79da34 Compare May 8, 2019 08:04
@MorrisJobke MorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 8, 2019
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 8, 2019
@MorrisJobke MorrisJobke merged commit a2ad5d0 into master May 8, 2019
@MorrisJobke MorrisJobke deleted the fix/13550/logging branch May 8, 2019 13:50
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented May 8, 2019

backport to stable16 in #15442

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented May 8, 2019

backport to stable15 in #15443

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented May 8, 2019

backport to stable14 in #15444

This was referenced May 8, 2019
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

Passwords in Clear Text in Logfile

7 participants

@blizzz @skjnldsv @rullzer @nickvergessen @ChristophWurst @MorrisJobke