Skip to content

Update shipped.json to include privacy and recommendations #15582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
May 17, 2019
Merged

Update shipped.json to include privacy and recommendations #15582

MorrisJobke merged 1 commit into from
May 17, 2019

Conversation

@georgehrke
Copy link
Member

@georgehrke georgehrke commented May 16, 2019 •
edited
Loading

The apps privacy and recommendations are not part of the shipped.json, which causes this error message in the update notifier:

Screen Shot 2019-05-16 at 23 13 23

Related issues:
nextcloud/privacy#118
nextcloud/recommendations#77

@georgehrke georgehrke requested review from MorrisJobke and rullzer May 16, 2019 20:33
@georgehrke
Copy link
Member Author

georgehrke commented May 16, 2019

/backport to stable16

This was referenced May 16, 2019
Closed
Closed
@rullzer rullzer added this to the Nextcloud 17 milestone May 16, 2019
@rullzer rullzer added bug 3. to review Waiting for reviews labels May 16, 2019
@MorrisJobke
Copy link
Member

MorrisJobke commented May 17, 2019

What about the viewer app?

@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 17, 2019
@georgehrke
Update shipped.json to include privacy, recommendations, viewer
1ac9132 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke force-pushed the bugfix/noid/update-shipped-apps branch from e863f00 to 1ac9132 Compare May 17, 2019 07:00
@georgehrke
Copy link
Member Author

georgehrke commented May 17, 2019

updated

@georgehrke georgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 17, 2019
@MorrisJobke MorrisJobke merged commit 0857d92 into master May 17, 2019
@MorrisJobke MorrisJobke deleted the bugfix/noid/update-shipped-apps branch May 17, 2019 08:49
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 17, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented May 17, 2019

backport to stable16 in #15592

@georgehrke georgehrke mentioned this pull request May 28, 2019
Closed
@Terrox
Copy link

Terrox commented Jul 6, 2019 •
edited
Loading

Same with 16.0.1 to 16.0.2 on stable channel

Version 
NC 16.0.1
A new version is available: Nextcloud 16.0.2
2 app has no update for this version available
Apps missing updates
Privacy ↗
Recommendations ↗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

6 participants

@georgehrke @MorrisJobke @Terrox @rullzer @ChristophWurst