Don't run repair step for every individual user, outsource that to background job #15697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckground job Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Member
|
/backport to stable16 |
rullzer
approved these changes
May 23, 2019
Member
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
Good stuff!
Didn't test but code makes sense.
MorrisJobke
deleted the
bugfix/noid/calendar_birthday_move_repair_to_background
branch
|
backport to stable16 in #15718 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RegenerateBirthdayCalendarsrepair step is not exactly mission critical and can get quite expensive, as it performs 1 individual sql insert for every user.Instead of running this during the repair / upgrade, just register a single background-job that does it.