Fix download entry shown on public share menu when not in mobile #15937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the output would just read "Failed asserting that true is false." or "Failed asserting that false is true.", which is not very informative when there are several assertFalse/True in a row. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Due to a typo in the variable name the rule was not properly parsed and applied. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
skjnldsv
reviewed
Jun 12, 2019
| // hide the download entry on the menu | ||
| // on public share when NOT on mobile | ||
| @media only screen and (min-width: $mobile_breakpoint + 1) { | ||
| @media only screen and (min-width: $breakpoint-mobile + 1) { |
skjnldsv
approved these changes
Jun 12, 2019
nachoparker
approved these changes
Jun 12, 2019
skjnldsv
added
4. to release
Member
skjnldsv
deleted the
fix-download-entry-shown-on-public-share-menu-when-not-in-mobile
branch
Member
|
I tested the change but must have forgotten to remove the cached css :| thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in #15199 due to a typo in the variable name.
I have also added messages to
assertFalse/assertTruein the related acceptance tests (as thanks to them is how I found the issue ;-) ) to make the failures more descriptive.