Properly load permissions in showActions #15992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
approved these changes
Jun 18, 2019
Member
Author
|
/backport to stable16 |
Member
Author
|
/backport to stable15 |
ChristophWurst
approved these changes
Jun 19, 2019
skjnldsv
added
4. to release
Member
|
Jsunit fails --------------
3193 | undefined
3194 | TypeError: undefined is not an object (evaluating 'fileList.setFiles') in apps/files/tests/js/filelistSpec.js (line 3460)
3195 | apps/files/tests/js/filelistSpec.js:3460:12
3196 | TypeError: undefined is not an object (evaluating 'fileList.showFileBusyState') in apps/files/tests/js/filelistSpec.js (line 3464)
3197 | apps/files/tests/js/filelistSpec.js:3464:12
3198 | TypeError: undefined is not an object (evaluating 'notificationStub.restore') in apps/files/tests/js/filelistSpec.js (line 187)
3199 | apps/files/tests/js/filelistSpec.js:187:19
3200 | PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests showFileBusyState accepts multiple input formats FAILED
3201 | TypeError: Attempted to wrap redirect which is already wrapped in build/lib/node_modules/sinon/pkg/sinon.js (line 3901)
3202 | undefined
3203
|
skjnldsv
added
2. developing
When setViewerMode(false) is called, the permissions should be fetched from the available dirInfo Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/noid/showActions-permission
branch
from
75091b2 to
51683fa
Compare
Member
Author
|
Ok, jsunit tests should be fine now. |
juliusknorr
added
3. to review
skjnldsv
added
4. to release
|
backport to stable16 in #16282 |
|
backport to stable15 in #16283 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setViewerMode(false) is called, the permissions should be fetched from the available dirInfo, otherwise creating a file is not possible.
Fixes #16238
Steps to reproduce: