Rename parameter in OCP.Toast for consistency with OC.Notification #16369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
approved these changes
Jul 12, 2019
Member
|
JSUnit fails |
Member
Author
It should be fixed now. |
This fixes HTML messages in "OC.Notification.showTemporary" (as "showHtml" was not set based on "isHTML"), and also makes OCP.Toast to keep the old OC.Notification API when used directly. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Member
|
Rebased and autosquashed. |
MorrisJobke
force-pushed
the
rename-parameter-in-ocp-toast-for-consistency-with-oc-notification
branch
from
3a1cc62 to
916c957
Compare
MorrisJobke
added
4. to release
delete-merged-branch
bot
deleted the
rename-parameter-in-ocp-toast-for-consistency-with-oc-notification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #15124
Fixes #16367
This fixes HTML messages in
OC.Notification.showTemporary(asshowHtmlwas not set based onisHTML), and also makes OCP.Toast to keep the old OC.Notification API when used directly.