Skip to content

Conversation

@juliusknorr
Copy link
Member

I just checked if text app is there, not if the old one was removed, so with this the update process will work just fine since the app is not marked as shipped anymore:

server/lib/base.php

Lines 383 to 393 in 5898e87

foreach ($incompatibleApps as $appInfo) {
if ($appManager->isShipped($appInfo['id'])) {
$incompatibleShippedApps[] = $appInfo['name'] . ' (' . $appInfo['id'] . ')';
}
}
if (!empty($incompatibleShippedApps)) {
$l = \OC::$server->getL10N('core');
$hint = $l->t('The files of the app %1$s were not replaced correctly. Make sure it is a version compatible with the server.', [implode(', ', $incompatibleShippedApps)]);
throw new \OC\HintException('The files of the app ' . implode(', ', $incompatibleShippedApps) . ' were not replaced correctly. Make sure it is a version compatible with the server.', $hint);
}

Fixes the update issue described in nextcloud/files_texteditor#169 (comment)

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@MorrisJobke MorrisJobke mentioned this pull request Jul 24, 2019
28 tasks
@MorrisJobke MorrisJobke merged commit 80b71dd into master Jul 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the shipped-texteditor branch July 24, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants