dont try to copy trash items to user if the user has not enough free space #16534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
reviewed
Jul 25, 2019
…space Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
changed the title
icewind1991
force-pushed
the
trash-copy-free-space
branch
from
648428b to
fafce34
Compare
MorrisJobke
reviewed
Jul 29, 2019
gary-kim
approved these changes
Sep 1, 2019
Member
gary-kim
left a comment
gary-kim
left a comment
There was a problem hiding this comment.
Improving readability would be nice as @MorrisJobke suggested but other than that, LGTM.
Co-Authored-By: Morris Jobke <hey@morrisjobke.de>
rullzer
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it tries to copy anyway a
CopyRecursiveExceptionwill be thrown later