Skip to content

Allow admin configured mounts to use user configured global credentials #16790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 2 commits into from
Sep 10, 2019
Merged

Allow admin configured mounts to use user configured global credentials #16790

rullzer merged 2 commits into from
Sep 10, 2019

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Aug 19, 2019

This is useful when there are multiple admin configured mounts that should all use the same user configured credentials

Fixes #2861

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Aug 19, 2019
@icewind1991 icewind1991 added this to the Nextcloud 17 milestone Aug 19, 2019
kesselb
kesselb reviewed Aug 19, 2019
View reviewed changes
rullzer
rullzer approved these changes Aug 19, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@icewind1991 icewind1991 force-pushed the admin-use-user-global-auth branch from ce7009b to 06057c7 Compare August 19, 2019 13:28
wiswedel
wiswedel reviewed Aug 22, 2019
View reviewed changes
wiswedel
wiswedel requested changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@wiswedel wiswedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When credentials haven't been entered or authentication wasn't successful (e.g. after pw change), click on a mount point currently says:

image

Selecting yes leads to

image

Better would be as it is for User entered, store in database:

image

This was referenced Aug 23, 2019
Merged
Merged
@wiswedel
Copy link
Contributor

wiswedel commented Sep 3, 2019

@icewind1991 any feedback to my change requests? Just wanna make sure this goes into 17.

@rullzer
Copy link
Member

rullzer commented Sep 3, 2019

@wiswedel he was on on holiday ;)

@wiswedel
Copy link
Contributor

wiswedel commented Sep 3, 2019

he was on on holiday ;)

Unbelievable

@rullzer rullzer modified the milestones: Nextcloud 17, Nextcloud 18 Sep 5, 2019
@rullzer
Copy link
Member

rullzer commented Sep 5, 2019

Master is no 18 development. If this needs to go into 17 please follow the normal backport procedures after merging.

@wiswedel
Copy link
Contributor

wiswedel commented Sep 9, 2019

Master is no 18 development. If this needs to go into 17 please follow the normal backport procedures after merging.

Ah, an auto-reference by a comment in the 17 beta PR made me assume this was actually supposed to be part of that PR.

@wiswedel
Copy link
Contributor

wiswedel commented Sep 9, 2019

/backport to stable17

@icewind1991
Allow admin configured mounts to use user configured global credentials
1d51b29 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the admin-use-user-global-auth branch from 06057c7 to eccf4dc Compare September 9, 2019 15:14
@icewind1991
allow setting user provided global credentials trough credentials popup
6036553 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the admin-use-user-global-auth branch from eccf4dc to 6036553 Compare September 9, 2019 15:15
@icewind1991
Copy link
Member Author

icewind1991 commented Sep 9, 2019

You can now configure the credentials as with "user provided"

ChristophWurst
ChristophWurst approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & works. Code looks good!

@rullzer rullzer merged commit 15e16d4 into master Sep 10, 2019
@rullzer rullzer deleted the admin-use-user-global-auth branch September 10, 2019 14:01
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 10, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Sep 10, 2019

backport to stable17 in #17090

@wiswedel
Copy link
Contributor

wiswedel commented Sep 13, 2019

Thanks a lot, @icewind1991 @rullzer @ChristophWurst @kesselb
Great work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselb kesselb kesselb left review comments

@wiswedel wiswedel wiswedel requested changes

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement feature: external storage

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

External storage: admin should be able to select the global credentials of a user for authentication purposes

6 participants

@icewind1991 @wiswedel @rullzer @ChristophWurst @kesselb