[stable15] Only cache the mimetype if the file exists #17540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise files access control will cache "application/octet-stream" for all the target node on: rename, move, copy and all other methods which create a new item To check this: 1. Add an automated tagging rule which tags on mimetype NOT "httpd/unix-directory" 2. Add an access control rule which checks for any mimetype 3. Create a folder and rename it, the folder should not be tagged, but it is Signed-off-by: Joas Schilling <coding@schilljs.com>
backportbot-nextcloud
bot
requested review from
blizzz,
juliusknorr,
nickvergessen and
rullzer
rullzer
approved these changes
Oct 14, 2019
juliusknorr
approved these changes
Oct 17, 2019
skjnldsv
reviewed
Oct 24, 2019
| * @param string $mimeType | ||
| * @return string | ||
| */ | ||
| protected function cacheAndReturnMimeType(string $storageId, ?string $path, string $mimeType): string { |
Member
There was a problem hiding this comment.
Suggested change
| protected function cacheAndReturnMimeType(string $storageId, ?string $path, string $mimeType): string { | |
| protected function cacheAndReturnMimeType(string $storageId, string $path, string $mimeType): string { |
@rullzer @juliushaertl @nickvergessen this is not working on server15!
This pr have been merged with failing jobs: https://drone.nextcloud.com/nextcloud/server/22464/5/3
Member
There was a problem hiding this comment.
yeah, just remove ?string and I think we need to remove string aswell?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #17332