Restore overwritten services after errors #1822
Merged
+46
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
… isolation Signed-off-by: Joas Schilling <coding@schilljs.com>
|
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @rullzer and @PVince81 to be potential reviewers. |
Member
|
please backport 👍 |
Member
|
👍 |
MorrisJobke
added
4. to release
This was referenced Oct 21, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the actual reason, why #1452 failed.
One test replaced app config, failed and therefor didn't restore the original (non-mocked) app config anymore.
Now we have a system in place which takes care of this problem in general,
but it wasn't used here.
So now I used the system everywhere and made sure the services are correctly restored in all cases.
@karlitschek I'd like to backport this since it's test only and helps when debugging tests on other PRs.
@MorrisJobke @rullzer