Skip to content

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Oct 20, 2016

People should be able to set the permissions before they share a file.

Todo:

  • Tests
  • Move menu to right location
  • Create nice icon indications instead of numeric indicator
    • Read (eye?)
    • Edit (pencil?)
    • Share (share icon?)

@LukasReschke as discussed.

CC: @nextcloud/javascript @nextcloud/designers

People should be able to set the permissions before they share a file.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@mention-bot
Copy link

@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81, @blizzz and @schiessle to be potential reviewers.

@jancborchardt jancborchardt added the design Design, UI, UX, etc. label Oct 20, 2016
@rullzer
Copy link
Member Author

rullzer commented Oct 24, 2016

@nextcloud/designers could you come up with the 3 icons? (Or well we have the share icon already). Now sure about the eye and pencil icon tough.

@MorrisJobke / @ChristophWurst could one of you make it look a bit fancier ;)

@Espina2
Copy link
Contributor

Espina2 commented Oct 24, 2016

@rullzer can you post a print screen for the screen that you are talking about?

@rullzer
Copy link
Member Author

rullzer commented Oct 24, 2016

selection_001

@Espina2
Copy link
Contributor

Espina2 commented Oct 24, 2016

Thanks.:)

Okey I will do a quick mockup for that. I suggest to put the options before or after the share form instead of having it in the same "line". @jancborchardt are using http://fontawesome.io/ or another similar, or you have some default guidelines for the icons?

@rullzer
Copy link
Member Author

rullzer commented Dec 16, 2016

So this might not be the best way to go. Close for now until we come up with a proper solution.

@rullzer rullzer closed this Dec 16, 2016
@rullzer rullzer deleted the permissions_before_share branch December 16, 2016 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants