Skip to content

Conversation

@Simounet
Copy link
Member

@Simounet Simounet commented Jan 27, 2020

Fix #19160

Hi there,
Thank you so much for this amazing piece of software.
Just wanted to fix a quick typo from the data's .htaccess. Let me know if I can add anything.
Have a nice day.

@Simounet Simounet force-pushed the fix/data-apache-htaccess-typo branch from aad344a to e1e0027 Compare January 27, 2020 16:22
@kesselb kesselb requested a review from MichaIng January 27, 2020 16:22
@kesselb kesselb added this to the Nextcloud 19 milestone Jan 27, 2020
@kesselb kesselb added 3. to review Waiting for reviews bug labels Jan 27, 2020
@kesselb
Copy link
Contributor

kesselb commented Jan 27, 2020

/backport to stable18

@kesselb
Copy link
Contributor

kesselb commented Jan 27, 2020

Thanks 👍

git commit --amend --signoff
git push --force-with-lease origin fix/data-apache-htaccess-typo

Would you mind to use the above command to fix the DCO? If you added / removed commits in the meantime the command is proably different.

@kesselb kesselb requested a review from rullzer January 27, 2020 16:26
@Simounet Simounet force-pushed the fix/data-apache-htaccess-typo branch from e1e0027 to cf09146 Compare January 27, 2020 16:27
@Simounet
Copy link
Member Author

Thanks +1

git commit --amend --signoff
git push --force-with-lease origin fix/data-apache-htaccess-typo

Would you mind to use the above command to fix the DCO? If you added / removed commits in the meantime the command is proably different.

Fixed and thanks for the quick reply!

@MichaIng
Copy link
Member

MichaIng commented Jan 27, 2020

The .htaccess in config btw is already correct (changed in the same PR): https://github.com/nextcloud/server/blob/master/config/.htaccess#L17

@MichaIng
Copy link
Member

MichaIng commented Feb 5, 2020

@Simounet
Would you mind to apply the requested change, as we should have this fix ready for next minor release (backport request is up). I hope it's clear that the buggy tag must be a closing tag.

Signed-off-by: Simounet <contact@simounet.net>
@Simounet Simounet force-pushed the fix/data-apache-htaccess-typo branch from cf09146 to a98f8b5 Compare February 5, 2020 10:18
@Simounet
Copy link
Member Author

Simounet commented Feb 5, 2020

Hello @MichaIng ,
Sorry for the late reply. I just fixed it.

@kesselb
Copy link
Contributor

kesselb commented Feb 5, 2020

/backport to stable18

@kesselb
Copy link
Contributor

kesselb commented Feb 5, 2020

cc @rullzer would be nice for 18.0.1.

@skjnldsv skjnldsv requested a review from MichaIng February 5, 2020 10:33
@MichaIng
Copy link
Member

MichaIng commented Feb 5, 2020

🚀

@skjnldsv skjnldsv merged commit 13cfb35 into nextcloud:master Feb 5, 2020
@welcome
Copy link

welcome bot commented Feb 5, 2020

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@backportbot-nextcloud
Copy link

backport to stable18 in #19302

@Simounet Simounet deleted the fix/data-apache-htaccess-typo branch April 19, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AH00566: request failed: malformed request line

5 participants