Prevent array access on integer in BaseResponse #19311
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OC\AppFramework\OCS\BaseResponse::toXML() method iterates over the array provided as its parameter. It checks (among other things) if the first character of the current key of that array is ‘@’, but it doesn’t check if that key is actually a string (it may be an integer). This commit adds the missing check. Signed-off-by: Grzegorz Szymaszek <gszymaszek@short.pl>
Member
Author
|
OK, nice to see it fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OC\AppFramework\OCS\BaseResponse::toXML()method iterates over the array provided as its parameter. It checks (among other things) if the first character of the current key of that array is@, but it doesn’t check if that key is actually a string (it may be an integer). This commit adds the missing check.Signed-off-by: Grzegorz Szymaszek gszymaszek@short.pl