Skip to content

Fix event type #19320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Feb 6, 2020
Merged

Fix event type #19320

rullzer merged 1 commit into from
Feb 6, 2020

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 6, 2020 •
edited
Loading

@nickvergessen
Fix event type
e2ca311 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 19 milestone Feb 6, 2020
@nickvergessen
Copy link
Member Author

nickvergessen commented Feb 6, 2020 •
edited
Loading

server/apps/files/lib/Listener/LegacyLoadAdditionalScriptsAdapter.php

Line 34 in 1b46621

use OCP\EventDispatcher\GenericEvent;

the type of the event changed

server/apps/files/lib/Controller/ViewController.php

Line 48 in f957ec0

use Symfony\Component\EventDispatcher\GenericEvent;

breaking the external app: nextcloud/external#179

@nickvergessen
Copy link
Member Author

nickvergessen commented Feb 6, 2020

/backport to stable18

@nickvergessen nickvergessen mentioned this pull request Feb 6, 2020
Closed
rullzer
rullzer approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@rullzer rullzer merged commit 2fb9103 into master Feb 6, 2020
@rullzer rullzer deleted the bugfix/external-179/fix-event-type branch February 6, 2020 19:31
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 6, 2020
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Feb 6, 2020

backport to stable18 in #19330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@kesselb kesselb Awaiting requested review from kesselb

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug regression

Projects

None yet

Milestone

Nextcloud 19

4 participants

@nickvergessen @rullzer @ChristophWurst