Adjust link to contributing.md #1960
Conversation
|
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @schiessle, @LukasReschke and @jancborchardt to be potential reviewers. |
settings/templates/help.php
Outdated
| <?php if($_['admin']) { ?> | ||
| <li> | ||
| <a href="https://github.com/nextcloud/server/blob/master/CONTRIBUTING.md" | ||
| <a href="https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md" |
There was a problem hiding this comment.
Since this is shipped, we now have dead links for all admins.
@LukasReschke can we add a redirect on some URL, so we can control the link in the future?
There was a problem hiding this comment.
Let's maybe change that to https://nextcloud.com/support/ ? Also links to some more resources and keeps support questions away from GH.
nickvergessen
force-pushed
the
adjust-link-to-contributing.md
branch
from
7ebd972 to
b1444e4
Compare
|
I just noticed, that we use the non-existing file in all our apps issue template:
Maybe we should revert #1761 to move it back into the root to avoid problems? @LukasReschke @MorrisJobke |
|
But we are using this in contacts and ihrer apps now too ... I think we should etablish this everywhere to keep the Root Directory as clean as possible, and to make those files easy to find 😅 @nickvergessen |
settings/templates/help.php
Outdated
| <a href="https://github.com/nextcloud/server/blob/master/CONTRIBUTING.md" | ||
| target="_blank" rel="noreferrer"> | ||
| <a href="https://nextcloud.com/support/" target="_blank" rel="noreferrer"> | ||
| <?php p($l->t('Issue tracker')); ?> ↗ |
I also think this is the way to go :( |
This reverts commit 9ebd8d8.
nickvergessen
force-pushed
the
adjust-link-to-contributing.md
branch
from
b1444e4 to
256f814
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
adjust-link-to-contributing.md
branch
from
256f814 to
d6f156f
Compare
|
Updated as discussed, @MorrisJobke @MariusBluem |
|
👍 |
|
Sure LGTM |
No description provided.