Fix invalid instantiation of TemplateResponse if client not found #19964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/backport to stable18 |
kesselb
commented
Mar 15, 2020
|
|
||
| namespace OCA\OAuth2\Tests\Controller; | ||
|
|
||
| use OCA\Files_Sharing\Tests\TestCase; |
Contributor
Author
There was a problem hiding this comment.
That's weird. I guess it was not intended to use OCA\Files_Sharing\Tests\TestCase as base class for LoginRedirectorControllerTest.
Contributor
Author
There was a problem hiding this comment.
Hopefully it's unrelated but a lot of tests failed related to sharing. Restarted the test a few hours ago but job is still pending. Probably the CI want's a weekend too.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
bug/19963/invalid-constructor-template-response
branch
from
86046f0 to
509af24
Compare
rullzer
approved these changes
Mar 15, 2020
|
backport to stable18 in #20008 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.