Fix language multiselect action #20019
Conversation
|
/backport to stable18 |
| vertical-align: baseline; | ||
| text-overflow: ellipsis; | ||
| overflow: hidden; | ||
| doesnotexist:-o-prefocus, .strengthify-wrapper { |
There was a problem hiding this comment.
OPERA hack for strengthify ;)
There was a problem hiding this comment.
wow, should/do we support opera? 🙈
There was a problem hiding this comment.
@GretaD Did you verify if that is still needed? As Opera is also chromium based nowadays.
There was a problem hiding this comment.
wow, should/do we support opera? see_no_evil
Don’t remove browsers just because you don’t know them. Opera Mini has 100 million users in Africa and it is more popular in the global market than Microsoft Edge. Chinese QQ Browsers has more market share than Firefox and desktop Safari combined.
Source: https://github.com/browserslist/browserslist#best-practices
There was a problem hiding this comment.
I saw that we use it also somewhere else, and went with it. Im fine to remove it
There was a problem hiding this comment.
We have to improve there anyway
https://github.com/nextcloud/browserslist-config/blob/master/browserlist.config.js
There was a problem hiding this comment.
Im fixing a support ticket with this pr, should we merge it and then i can fix it also here: https://github.com/nextcloud/browserslist-config/blob/master/browserlist.config.js?
There was a problem hiding this comment.
sooo, is it good to go? :D
Signed-off-by: GretaD <gretadoci@gmail.com>
GretaD
force-pushed
the
bugfix/fix_lanuage_multiselect
branch
from
fe8c9ed to
e45d5d3
Compare
georgehrke
left a comment
georgehrke
left a comment
There was a problem hiding this comment.
Code looks good
Tested and works 👍
ChristophWurst
added
4. to release
|
backport to stable18 in #20136 |
fixes #19912