fix dav browser error page not styled #20042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
skjnldsv
approved these changes
Mar 20, 2020
skjnldsv
reviewed
Mar 20, 2020
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
I meant to comment, wrong issue.
Can we use the existing core templates? :)
rullzer
approved these changes
Mar 20, 2020
Member
Author
Yes, but it also needs to be repaired:
Depending on the error code we can also deliver the 404, which looks good, but the generic exception one does not. |
Member
Author
|
@skjnldsv pushed logic to use core templates. the exception one is ugly, but the 404 is now nice. good enough for this fix? screenshot updated. |
blizzz
added
3. to review
skjnldsv
reviewed
Mar 20, 2020
apps/dav/templates/exception.php
Outdated
| /** @param $_ array */ | ||
| ?> | ||
| <span class="error error-wide"> | ||
| <div class="body-login-container update"> |
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/noid/styled-dav-browser-error
branch
from
6ca2f42 to
82f8a16
Compare
blizzz
added
4. to release
skjnldsv
approved these changes
Mar 21, 2020
Member
Author
|
/backport to stable18 |
|
backport to stable18 in #20104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
(e.g. https://my.nxt.cld/remote.php/webdav/Foo/Bar/Foobar.pdf)
Now:
@nextcloud/designers please help by polishing the design. I bet you know which classes to use :)