Auto accept group shares for users added to a group

[rullzer]

In case auto accepting is enabled (the default). Users that are newly
added to a group should not have to accept those shares.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

[rullzer]

/backport to stable18

[nickvergessen]

Didn't testy but makes sense

[kesselb]

May fix #19520

[rullzer]

May fix #19520

probably

[rullzer]

Testing is easy.

1. Create a new group
2. Share a file to this group
3. Create a new user
4. Add this user to the group
5. Login as this user

before: Having to accept the group share

after: not having to accept the group share

[backportbot-nextcloud]

backport to stable18 in #20161

[skjnldsv]

10000th PR to be merged! 🎉

[kklem0]

Quick question @rullzer , does this work with LDAP group as well?

[jsalatiel]

I am running 18.06 with ldap/saml activated. New users added to the group can not see the shared folders to the group even though they have settings->sharing-> "Accept user and groups share by default" selected.
They must go to Shares -> pending Shares and accept to make the folder appear.

[tofuSCHNITZEL]

yes same with me and 18.0.6

[liejuntao001]

I am running 18.06 with ldap/saml activated. New users added to the group can not see the shared folders to the group even though they have settings->sharing-> "Accept user and groups share by default" selected.
They must go to Shares -> pending Shares and accept to make the folder appear.

I have the same setup 18.06, but the new user has nothing in Shares -> pending Shares.
Before upgrading to 18.06, when it was 18.04, the new user could see the Shares -> pending Shares to accept the sharing.
I think this is a breakage.

[demlak]

Still not working on new ldap-users in nextcloud 19.0.4
Already shared files and folders are still pending shares.

[smirta]

Does your cron.php-Job run? If not, you'll need to make sure that it is running with the latest php-runtime. It fails to run with php7.2. You'll need to change to php7.3. We had to adjust the systemd-unit. E.g.:

ExecStart=/opt/rh/rh-php72/root/usr/bin/php -f /var/www/html/nextcloud/cron.php

to

ExecStart=/opt/rh/rh-php73/root/usr/bin/php -f /var/www/html/nextcloud/cron.php