[stable18] Close updatenotification channel selector on click outside #20155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the vue-click-outside package was set up and imported, it wasn't being used yet. This commit sets up to use vue-click-outside on the channel selector in updatenotification Signed-off-by: Gary Kim <gary@garykim.dev>
gary-kim
requested review from
juliusknorr,
nickvergessen,
rullzer and
skjnldsv
skjnldsv
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #20117
While the vue-click-outside package was set up and
imported, it wasn't being used yet.
This commit sets up to use vue-click-outside
on the channel selector in updatenotification
So close!
Signed-off-by: Gary Kim gary@garykim.dev