Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Nov 7, 2016
@nickvergessen nickvergessen added this to the Nextcloud 11.0 milestone Nov 7, 2016
@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke, @bartv2 and @BernhardPosselt to be potential reviewers.

@rullzer
Copy link
Member

rullzer commented Nov 7, 2016

Jikes my bad! LGTM

@MorrisJobke
Copy link
Member

here is also this weird error message, @nickvergessen :

PHP Warning:  file_get_contents(/drone/src/github.com/nextcloud/server/lib/private/RichObjectStrings/../../public/RichObjectStrings/definitions.json): failed to open stream: No such file or directory in /drone/src/github.com/nextcloud/server/lib/private/RichObjectStrings/Validator.php on line 46

Signed-off-by: Joas Schilling <coding@schilljs.com>
@rullzer rullzer merged commit 100cec5 into master Nov 8, 2016
@rullzer rullzer deleted the fix-preview-urls branch November 8, 2016 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants