get only groupids in default share backend #20815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of getting the full group object and then only using the id anyway Signed-off-by: Robin Appelman <robin@icewind.nl>
rullzer
requested review from
ChristophWurst,
MorrisJobke,
danxuliu and
juliusknorr
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Member
|
I fixed the code style and the tests to only return the group IDs and not the groups itself. |
MorrisJobke
added
4. to release
Merged
Member
|
Test failures are unrelated as one was for the object storage and the other about versioning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of getting the full group object and then only using the id anyway
Signed-off-by: Robin Appelman robin@icewind.nl