Skip to content

Conversation

@georgehrke
Copy link
Member

https://sabre.io/dav/clients/osx-addressbook/

This PR is adding support for ctag:

This client requires impementation of the proprietary '{http://calendarserver.org/ns/}getctag' property. Without it, it will simply not request any vcards.

This PR renames app-generated to z-app-generated:

OS X addressbook can only ever work with 1 address book. Even though the CardDAV standard makes it easy for users to own more than one addressbook, this is not supported.

Unfortunately this means that if a user has more than one addressbook in their account, only the 'first' will show up, and contacts from other addressbooks are completely hidden to the user.

This can cause for a lot of confusion, and there is no obvious solution other than simply enforce a 1 address book limit for users.

tl;dr:
Without this PR, macOS Contacts will only show the 5 contacts from the contacts interaction addressbook, but all the contacts from the personal addressbook will be gone.

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke added the 3. to review Waiting for reviews label May 7, 2020
@georgehrke georgehrke requested review from ChristophWurst and rullzer and removed request for rullzer May 7, 2020 14:38
@georgehrke
Copy link
Member Author

/backport stable19

@georgehrke georgehrke requested a review from rullzer May 7, 2020 14:38
@georgehrke
Copy link
Member Author

While the sabre/dav docs say that the one addressbook limitation affect only OS X 10.6 until OS X 10.10, i'm still affected by it on macOS 10.15. So I guess the docs are not up to date.

…rts only one and will pick the first one alphabetically

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke force-pushed the bugfix/noid/macos_contacts_sync_prefer_personal_over_app-generated branch from 53fb7ff to cbbe11f Compare May 7, 2020 14:48
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@georgehrke
Copy link
Member Author

Test failures unrelated, merging

@georgehrke georgehrke merged commit a45f403 into master May 8, 2020
@georgehrke georgehrke deleted the bugfix/noid/macos_contacts_sync_prefer_personal_over_app-generated branch May 8, 2020 10:03
@georgehrke
Copy link
Member Author

/backport to stable19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants